fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 13:48:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

isl: Update isl_swizzle_supports_rendering comment

Browse source 
Bspec 57023: RENDER_SURFACE_STATE:: Shader Channel Select Red

   "Render Target messages do not support swapping of colors with
   alpha. The Red, Green, or Blue Shader Channel Selects do not
   support SCS_ALPHA. The Shader Channel Select Alpha does not support
   SCS_RED, SCS_GREEN, or SCS_BLUE."

Cc: mesa-stable
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28791>
(cherry picked from commit 2d8686ccd5)
This commit is contained in:
Sagar Ghuge 2024-04-19 08:52:28 -07:00 • committed by Eric Engestrom
parent de5be437a9
commit f174be0a3e
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -124,7 +124,7 @@
"description": "isl: Update isl_swizzle_supports_rendering comment",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

7
src/intel/isl/isl.c
View file

@ -4064,6 +4064,13 @@ isl_swizzle_supports_rendering(const struct intel_device_info *devinfo,
*
* "For Render Target, this field MUST be programmed to
* value = SCS_ALPHA."
*
* Bspec 57023: RENDER_SURFACE_STATE:: Shader Channel Select Red
*
* "Render Target messages do not support swapping of colors with
* alpha. The Red, Green, or Blue Shader Channel Selects do not
* support SCS_ALPHA. The Shader Channel Select Alpha does not support
* SCS_RED, SCS_GREEN, or SCS_BLUE."
*/
return (swizzle.r == ISL_CHANNEL_SELECT_RED ||
swizzle.r == ISL_CHANNEL_SELECT_GREEN ||