From f174be0a3e96c11522c8a947ecb950d8b005ed46 Mon Sep 17 00:00:00 2001 From: Sagar Ghuge Date: Fri, 19 Apr 2024 08:52:28 -0700 Subject: [PATCH] isl: Update isl_swizzle_supports_rendering comment Bspec 57023: RENDER_SURFACE_STATE:: Shader Channel Select Red "Render Target messages do not support swapping of colors with alpha. The Red, Green, or Blue Shader Channel Selects do not support SCS_ALPHA. The Shader Channel Select Alpha does not support SCS_RED, SCS_GREEN, or SCS_BLUE." Cc: mesa-stable Signed-off-by: Sagar Ghuge Reviewed-by: Lionel Landwerlin Part-of: (cherry picked from commit 2d8686ccd55b9df3396be1feb967bc9026f38b15) --- .pick_status.json | 2 +- src/intel/isl/isl.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index cf0eb6db50b..c5ba3550b2a 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -124,7 +124,7 @@ "description": "isl: Update isl_swizzle_supports_rendering comment", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 850b7a1cc95..1e19db1c903 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -4064,6 +4064,13 @@ isl_swizzle_supports_rendering(const struct intel_device_info *devinfo, * * "For Render Target, this field MUST be programmed to * value = SCS_ALPHA." + * + * Bspec 57023: RENDER_SURFACE_STATE:: Shader Channel Select Red + * + * "Render Target messages do not support swapping of colors with + * alpha. The Red, Green, or Blue Shader Channel Selects do not + * support SCS_ALPHA. The Shader Channel Select Alpha does not support + * SCS_RED, SCS_GREEN, or SCS_BLUE." */ return (swizzle.r == ISL_CHANNEL_SELECT_RED || swizzle.r == ISL_CHANNEL_SELECT_GREEN ||