fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 06:58:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

r600: fix refcnt imbalance related to evergreen_set_shader_images()

Browse source 
Indeed, the reference was overwritten.

For instance, this issue is triggered with:
"piglit/bin/shader_runner tests/spec/arb_shader_image_load_store/execution/write-to-rendered-image.shader_test -auto -fbo"
while setting GALLIUM_REFCNT_LOG=refcnt.log.

Fixes: a6b3792843 ("r600: add core pieces of image support.")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22394>
(cherry picked from commit 4f42d3b843)
This commit is contained in:
Patrick Lerda 2023-04-01 23:08:09 +02:00 • committed by Eric Engestrom
parent de36799f15
commit eb3df9b189
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -580,7 +580,7 @@
"description": "r600: fix refcnt imbalance related to evergreen_set_shader_images()",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "a6b379284365e8adee780b691596d3a66de1ba93"
},

3
src/gallium/drivers/r600/evergreen_state.c
View file

@ -4283,8 +4283,9 @@ static void evergreen_set_shader_images(struct pipe_context *ctx,
r600_context_add_resource_size(ctx, image);
struct pipe_resource *const pipe_saved = rview->base.resource;
rview->base = *iview;
rview->base.resource = NULL;
rview->base.resource = pipe_saved;
pipe_resource_reference((struct pipe_resource **)&rview->base.resource, image);
evergreen_setup_immed_buffer(rctx, rview, iview->format);