fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-04 00:30:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

vc4: do not access member of a NULL structure

Browse source 
Check if the structure is NULL before trying to get access to its
members.

This has been detected by the Undefined Behaviour Sanitizer (UBSan).

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29911>
This commit is contained in:
Juan A. Suarez Romero 2024-06-26 10:43:11 +02:00 • committed by Marge Bot
parent 5e09b2b3f3
commit eab3ee8d71
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/gallium/drivers/vc4/vc4_fence.c
View file

@ -65,7 +65,8 @@ vc4_fence_reference(struct pipe_screen *pscreen,
struct vc4_fence *f = vc4_fence(pf);
struct vc4_fence *old = *p;
if (pipe_reference(&(*p)->reference, &f->reference)) {
if (pipe_reference(old ? &old->reference : NULL,
f ? &f->reference : NULL)) {
if (old->fd >= 0)
close(old->fd);
free(old);