From eab3ee8d71075d8c1e5b511ed4ed7699d4e66a5e Mon Sep 17 00:00:00 2001 From: "Juan A. Suarez Romero" Date: Wed, 26 Jun 2024 10:43:11 +0200 Subject: [PATCH] vc4: do not access member of a NULL structure Check if the structure is NULL before trying to get access to its members. This has been detected by the Undefined Behaviour Sanitizer (UBSan). Reviewed-by: Iago Toral Quiroga Signed-off-by: Juan A. Suarez Romero Part-of: --- src/gallium/drivers/vc4/vc4_fence.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/vc4/vc4_fence.c b/src/gallium/drivers/vc4/vc4_fence.c index ac49a7be337..0e8859aff9b 100644 --- a/src/gallium/drivers/vc4/vc4_fence.c +++ b/src/gallium/drivers/vc4/vc4_fence.c @@ -65,7 +65,8 @@ vc4_fence_reference(struct pipe_screen *pscreen, struct vc4_fence *f = vc4_fence(pf); struct vc4_fence *old = *p; - if (pipe_reference(&(*p)->reference, &f->reference)) { + if (pipe_reference(old ? &old->reference : NULL, + f ? &f->reference : NULL)) { if (old->fd >= 0) close(old->fd); free(old);