fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-16 12:40:34 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pco: Fix multiview sampling of subpass input attachments
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
When sampling a subpass input attachment when multiview is been used
the the view index is required.

This becomes an extra output from the vertex shader which is then
iterated into the fragment shader input where it is then used as the
array layer index when sampling the subpass input attachment.

However this extra output was not having its interpolation mode
configured correctly leading to incorrect instructions being added
causing the view index to always be zero and thus sampling the
subpass input attachment incorrectly.

Fix is to make sure the view index interpolation mode is set to flat.

Fix:
dEQP-VK.multiview.input_attachments.no_queries.1_2_4_8_16_32
dEQP-VK.multiview.input_attachments.no_queries.1_2_4_8
dEQP-VK.multiview.input_attachments.no_queries.15_15_15_15
dEQP-VK.multiview.input_attachments.no_queries.15
dEQP-VK.multiview.input_attachments.no_queries.5_10_5_10
dEQP-VK.multiview.input_attachments.no_queries.8_1_1_8
dEQP-VK.multiview.input_attachments.no_queries.8
dEQP-VK.multiview.input_attachments.no_queries.max_multi_view_view_count
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.1_2_4_8_16_32
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.1_2_4_8
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.15_15_15_15
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.15
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.5_10_5_10
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.8_1_1_8
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.8
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.max_multi_view_view_count

Signed-off-by: Nick Hamilton <nick.hamilton@imgtec.com>
Reviewed-by: Simon Perretta <simon.perretta@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39715>
This commit is contained in:
Nick Hamilton 2026-02-02 13:15:11 +00:00 • committed by Marge Bot
parent ba102224ab
commit cf0786c766
2 changed files with 7 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/imagination/ci/bxs-4-64-fails.txt
View file

@ -27,22 +27,6 @@ dEQP-VK.memory.mapping.dedicated_alloc.image.full.variable.implicit_unmap,Timeou
dEQP-VK.memory.mapping.dedicated_alloc.image.full.variable.implicit_unmap_map2,Timeout
dEQP-VK.memory.mapping.suballocation.full.variable.implicit_unmap,Timeout
dEQP-VK.memory.mapping.suballocation.full.variable.implicit_unmap_map2,Timeout
dEQP-VK.multiview.input_attachments.no_queries.15,Fail
dEQP-VK.multiview.input_attachments.no_queries.15_15_15_15,Fail
dEQP-VK.multiview.input_attachments.no_queries.1_2_4_8,Fail
dEQP-VK.multiview.input_attachments.no_queries.1_2_4_8_16_32,Fail
dEQP-VK.multiview.input_attachments.no_queries.5_10_5_10,Fail
dEQP-VK.multiview.input_attachments.no_queries.8,Fail
dEQP-VK.multiview.input_attachments.no_queries.8_1_1_8,Fail
dEQP-VK.multiview.input_attachments.no_queries.max_multi_view_view_count,Fail
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.15,Fail
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.15_15_15_15,Fail
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.1_2_4_8,Fail
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.1_2_4_8_16_32,Fail
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.5_10_5_10,Fail
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.8,Fail
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.8_1_1_8,Fail
dEQP-VK.multiview.renderpass2.input_attachments.no_queries.max_multi_view_view_count,Fail
dEQP-VK.pipeline.monolithic.empty_fs.masked_samples,Fail
dEQP-VK.pipeline.monolithic.stencil.no_stencil_att.dynamic_rendering.dynamic_enable.d24_unorm_s8_uint,Fail
dEQP-VK.pipeline.monolithic.stencil.no_stencil_att.dynamic_rendering.dynamic_enable.d32_sfloat_s8_uint,Fail

11
src/imagination/pco/pco_nir_tex.c
View file

@ -1353,10 +1353,13 @@ static nir_def *lower_image(nir_builder *b, nir_instr *instr, void *cb_data)
.num_slots = 1,
});
nir_get_variable_with_location(b->shader,
nir_var_shader_in,
data->fs.view_index_slot,
glsl_uint_type());
nir_variable *view_index_var =
nir_get_variable_with_location(b->shader,
nir_var_shader_in,
data->fs.view_index_slot,
glsl_uint_type());
view_index_var->data.interpolation = INTERP_MODE_FLAT;
}
coords = nir_pad_vector(b, coords, 3);