fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 13:48:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

tu: Fix indices of drm_msm_gem_submit_cmd when filling them

Browse source 
For some reason CTS doesn't trigger the issue...
When submit entry is not filled - kernel says:
 [drm:msm_ioctl_gem_submit] *ERROR* invalid type: 00000000

Fixes: dbae9fa7d8
("tu: implement sysmem vs gmem autotuner")

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16474>
(cherry picked from commit 9a11ad7efd)
This commit is contained in:
Danylo Piliaiev 2022-05-12 15:47:58 +03:00 • committed by Dylan Baker
parent 87c98bed29
commit cdc27459bf
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -436,7 +436,7 @@
"description": "tu: Fix indices of drm_msm_gem_submit_cmd when filling them",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "dbae9fa7d8412252c96e53ef3d50f4349969928a"
},

2
src/freedreno/vulkan/tu_drm.c
View file

@ -964,6 +964,7 @@ tu_queue_build_msm_gem_submit_cmds(struct tu_queue *queue,
&dev->perfcntrs_pass_cs_entries[submit->perf_pass_index];
tu_fill_msm_gem_submit(dev, &cmds[entry_idx], perf_cs_entry);
entry_idx++;
}
for (unsigned i = 0; i < cs->entry_count; ++i, ++entry_idx) {
@ -975,6 +976,7 @@ tu_queue_build_msm_gem_submit_cmds(struct tu_queue *queue,
submit->u_trace_submission_data->cmd_trace_data[j].timestamp_copy_cs;
if (ts_cs) {
tu_fill_msm_gem_submit(dev, &cmds[entry_idx], &ts_cs->entries[0]);
entry_idx++;
}
}
}