From cdc27459bf42e3fdd45876ad0287e09ab8cde47a Mon Sep 17 00:00:00 2001 From: Danylo Piliaiev Date: Thu, 12 May 2022 15:47:58 +0300 Subject: [PATCH] tu: Fix indices of drm_msm_gem_submit_cmd when filling them For some reason CTS doesn't trigger the issue... When submit entry is not filled - kernel says: [drm:msm_ioctl_gem_submit] *ERROR* invalid type: 00000000 Fixes: dbae9fa7d8412252c96e53ef3d50f4349969928a ("tu: implement sysmem vs gmem autotuner") Signed-off-by: Danylo Piliaiev Part-of: (cherry picked from commit 9a11ad7efd56d28e1c83aaec5cecb7fa7720fc90) --- .pick_status.json | 2 +- src/freedreno/vulkan/tu_drm.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index f790f59435f..01529a1591f 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -436,7 +436,7 @@ "description": "tu: Fix indices of drm_msm_gem_submit_cmd when filling them", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "dbae9fa7d8412252c96e53ef3d50f4349969928a" }, diff --git a/src/freedreno/vulkan/tu_drm.c b/src/freedreno/vulkan/tu_drm.c index 3be7a5ea240..3b6641d4362 100644 --- a/src/freedreno/vulkan/tu_drm.c +++ b/src/freedreno/vulkan/tu_drm.c @@ -964,6 +964,7 @@ tu_queue_build_msm_gem_submit_cmds(struct tu_queue *queue, &dev->perfcntrs_pass_cs_entries[submit->perf_pass_index]; tu_fill_msm_gem_submit(dev, &cmds[entry_idx], perf_cs_entry); + entry_idx++; } for (unsigned i = 0; i < cs->entry_count; ++i, ++entry_idx) { @@ -975,6 +976,7 @@ tu_queue_build_msm_gem_submit_cmds(struct tu_queue *queue, submit->u_trace_submission_data->cmd_trace_data[j].timestamp_copy_cs; if (ts_cs) { tu_fill_msm_gem_submit(dev, &cmds[entry_idx], &ts_cs->entries[0]); + entry_idx++; } } }