fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-20 07:20:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

freedreno/a6xx: Fix GRAS_LRZ_BUFFER_PITCH

Browse source 
The pitch is in bytes, rather than pixels, whereas internally lrz_layout
uses a pitch in pixels.  Adjust the xml and state emit accordingly.

Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38930>
This commit is contained in:
Rob Clark 2025-12-12 07:58:01 -08:00 • committed by Marge Bot
parent 17b567485a
commit cb201e5755
3 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/freedreno/registers/adreno/a6xx.xml
View file

@ -2006,7 +2006,7 @@ by a particular renderpass/blit.
<reg64 offset="0x8104" name="GRAS_LRZ_BUFFER_BASE" align="256" type="waddress" usage="rp_blit" variants="A8XX-"/> <reg64 offset="0x8104" name="GRAS_LRZ_BUFFER_BASE" align="256" type="waddress" usage="rp_blit" variants="A8XX-"/>
<bitset name="a6xx_gras_lrz_buffer_pitch" inline="yes"> <bitset name="a6xx_gras_lrz_buffer_pitch" inline="yes">
<bitfield name="PITCH" low="0" high="7" shr="5" type="uint"/> <bitfield name="PITCH" low="0" high="7" shr="6" type="uint"/>
<bitfield name="ARRAY_PITCH" low="10" high="28" shr="8" type="uint"/> <bitfield name="ARRAY_PITCH" low="10" high="28" shr="8" type="uint"/>
</bitset> </bitset>

2
src/freedreno/vulkan/tu_lrz.cc
View file

@ -131,7 +131,7 @@ tu6_emit_lrz_buffer(struct tu_cs *cs, struct tu_image *depth_image)
tu_cs_emit_regs( tu_cs_emit_regs(
cs, GRAS_LRZ_BUFFER_BASE(CHIP, .qword = lrz_iova), cs, GRAS_LRZ_BUFFER_BASE(CHIP, .qword = lrz_iova),
GRAS_LRZ_BUFFER_PITCH( GRAS_LRZ_BUFFER_PITCH(
CHIP, .pitch = depth_image->lrz_layout.lrz_pitch, CHIP, .pitch = depth_image->lrz_layout.lrz_pitch * sizeof(uint16_t),
.array_pitch = depth_image->lrz_layout.lrz_layer_size), .array_pitch = depth_image->lrz_layout.lrz_layer_size),
A6XX_GRAS_LRZ_FAST_CLEAR_BUFFER_BASE(.qword = lrz_fc_iova)); A6XX_GRAS_LRZ_FAST_CLEAR_BUFFER_BASE(.qword = lrz_fc_iova));

4
src/gallium/drivers/freedreno/a6xx/fd6_gmem.cc
View file

@ -266,7 +266,9 @@ emit_lrz(fd_cs &cs, struct fd_batch *batch, struct fd_batch_subpass *subpass)
crb.attach_bo(subpass->lrz); crb.attach_bo(subpass->lrz);
crb.add(GRAS_LRZ_BUFFER_BASE(CHIP, .bo = subpass->lrz)); crb.add(GRAS_LRZ_BUFFER_BASE(CHIP, .bo = subpass->lrz));
crb.add(GRAS_LRZ_BUFFER_PITCH(CHIP, .pitch = zsbuf->lrz_layout.lrz_pitch)); crb.add(GRAS_LRZ_BUFFER_PITCH(CHIP,
.pitch = zsbuf->lrz_layout.lrz_pitch * sizeof(uint16_t),
));
crb.add(A6XX_GRAS_LRZ_FAST_CLEAR_BUFFER_BASE( crb.add(A6XX_GRAS_LRZ_FAST_CLEAR_BUFFER_BASE(
.bo = zsbuf->lrz_layout.lrz_fc_size ? subpass->lrz : NULL, .bo = zsbuf->lrz_layout.lrz_fc_size ? subpass->lrz : NULL,
.bo_offset = zsbuf->lrz_layout.lrz_fc_offset .bo_offset = zsbuf->lrz_layout.lrz_fc_offset