fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-25 18:00:52 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

intel/isl: Always set EnableUnormPathInColorPipe

Browse source 
The TGL PRM says,

   This bit should never be programmed to 0

So, set it to true. I chose not to use the MBO attribute in genxml
because the field lacks the "Format: MBO" line in the PRM.

We previously made this programming conditional with commit 2e1be771e4
because of tests failing in
dEQP-GLES3.functional.texture.specification.tex*depth*. However, those
failures were fixed when we started using gl_FragDepth for depth buffer
copies in commit 6cec618e82.

Note: when bisecting this, I cherry-picked commit 7a68045b5d in order
to get past build failures related to a deprecated python function.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31066>
This commit is contained in:
Nanley Chery 2024-09-03 08:34:43 -04:00 • committed by Marge Bot
parent fa51595c7f
commit c92e49e8f4
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/intel/isl/isl_surface_state.c
View file

@ -545,12 +545,11 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state,
#endif
#if GFX_VER >= 11 && GFX_VERx10 < 125
/* We've seen dEQP failures when enabling this bit with UINT formats,
* which particularly affects blorp_copy() operations. It shouldn't
* have any effect on UINT textures anyway, so disable it for them.
/* From the TGL PRM,
*
* This bit should never be programmed to 0
*/
s.EnableUnormPathInColorPipe =
!isl_format_has_int_channel(info->view->format);
s.EnableUnormPathInColorPipe = true;
#endif
s.CubeFaceEnablePositiveZ = 1;