From c92e49e8f4a7ea2aaa8c13e77f61a36a3192b89e Mon Sep 17 00:00:00 2001 From: Nanley Chery Date: Tue, 3 Sep 2024 08:34:43 -0400 Subject: [PATCH] intel/isl: Always set EnableUnormPathInColorPipe The TGL PRM says, This bit should never be programmed to 0 So, set it to true. I chose not to use the MBO attribute in genxml because the field lacks the "Format: MBO" line in the PRM. We previously made this programming conditional with commit 2e1be771e47 because of tests failing in dEQP-GLES3.functional.texture.specification.tex*depth*. However, those failures were fixed when we started using gl_FragDepth for depth buffer copies in commit 6cec618e82a. Note: when bisecting this, I cherry-picked commit 7a68045b5d3 in order to get past build failures related to a deprecated python function. Reviewed-by: Kenneth Graunke Part-of: --- src/intel/isl/isl_surface_state.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index 658f9976907..da9ef366afe 100644 --- a/src/intel/isl/isl_surface_state.c +++ b/src/intel/isl/isl_surface_state.c @@ -545,12 +545,11 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state, #endif #if GFX_VER >= 11 && GFX_VERx10 < 125 - /* We've seen dEQP failures when enabling this bit with UINT formats, - * which particularly affects blorp_copy() operations. It shouldn't - * have any effect on UINT textures anyway, so disable it for them. + /* From the TGL PRM, + * + * This bit should never be programmed to 0 */ - s.EnableUnormPathInColorPipe = - !isl_format_has_int_channel(info->view->format); + s.EnableUnormPathInColorPipe = true; #endif s.CubeFaceEnablePositiveZ = 1;