fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 04:38:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

kk: Force attachment load as temp solution to preserve attachment

Browse source 
Attachment preserve is not correctly handled due to multiple issues:
 - No knowledge that we need to do that from render pass
 - Setting VkEvent from command buffers break MTLRenderPass
 - Pipeline barriers break MTLRenderPasses
 - vkCmdBeginRendering and vkCmdEndRendering don't account for it

Need to handle all those above first before we can have efficient
MTLRenderPasses implemented.

Acked-by: Arcady Goldmints-Orlov <arcady@lunarg.com>
Signed-off-by: Aitor Camacho <aitor@lunarg.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38612>
This commit is contained in:
Aitor Camacho 2025-11-24 16:51:02 +09:00 • committed by Marge Bot
parent fa420a8649
commit c6ad0f781a
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/kosmickrisp/vulkan/kk_cmd_draw.c
View file

@ -111,6 +111,10 @@ kk_fill_common_attachment_description(
force_attachment_load
? MTL_LOAD_ACTION_LOAD
: vk_attachment_load_op_to_mtl_load_action(info->loadOp);
/* TODO_KOSMICKRISP Need to tackle issue #14344 */
if (load_action == MTL_LOAD_ACTION_DONT_CARE)
load_action = MTL_LOAD_ACTION_LOAD;
mtl_render_pass_attachment_descriptor_set_load_action(descriptor,
load_action);
/* We need to force attachment store to correctly handle situations where the