From c6ad0f781a5da6f3c3011e0030d9d38483738571 Mon Sep 17 00:00:00 2001 From: Aitor Camacho Date: Mon, 24 Nov 2025 16:51:02 +0900 Subject: [PATCH] kk: Force attachment load as temp solution to preserve attachment Attachment preserve is not correctly handled due to multiple issues: - No knowledge that we need to do that from render pass - Setting VkEvent from command buffers break MTLRenderPass - Pipeline barriers break MTLRenderPasses - vkCmdBeginRendering and vkCmdEndRendering don't account for it Need to handle all those above first before we can have efficient MTLRenderPasses implemented. Acked-by: Arcady Goldmints-Orlov Signed-off-by: Aitor Camacho Part-of: --- src/kosmickrisp/vulkan/kk_cmd_draw.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/kosmickrisp/vulkan/kk_cmd_draw.c b/src/kosmickrisp/vulkan/kk_cmd_draw.c index 7bf2ee4c1f9..6cf9a008547 100644 --- a/src/kosmickrisp/vulkan/kk_cmd_draw.c +++ b/src/kosmickrisp/vulkan/kk_cmd_draw.c @@ -111,6 +111,10 @@ kk_fill_common_attachment_description( force_attachment_load ? MTL_LOAD_ACTION_LOAD : vk_attachment_load_op_to_mtl_load_action(info->loadOp); + + /* TODO_KOSMICKRISP Need to tackle issue #14344 */ + if (load_action == MTL_LOAD_ACTION_DONT_CARE) + load_action = MTL_LOAD_ACTION_LOAD; mtl_render_pass_attachment_descriptor_set_load_action(descriptor, load_action); /* We need to force attachment store to correctly handle situations where the