fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-02 11:40:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

gfxstream: add support for VK_KHR_maintenance5 + VK_EXT_host_image_copy

Browse source 
In newer versions of vk.xml, VK_EXT_host_image_copy also
provides vkGetImageSubresourceLayout2EXT.  Autogen for
VK_EXT_host_image_copy fails without VK_KHR_maintainance5.

For some reason, onGenCmd(..) for vkGetImageSubresourceLayout2EXT
is requires VK_EXT_host_image_copy.  This goes back into reg.py
in vulkan-docs.

Interestingly, the Android's libvulkan doesn't use
vkGetImageSubresourceLayout2EXT, nor does it check for
VK_EXT_image_compression_control before using it.

https://android-review.googlesource.com/c/platform/frameworks/native/+/2016419

Thus, we can have VK_EXT_host_image_copy provide the function.

Maybe we can revert this if the function isn't used by libvulkan
aswell.

Reviewed-by: Aaron Ruby <aruby@blackberry.com>
Acked-by: Yonggang Luo <luoyonggang@gmail.com>
Acked-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27246>
This commit is contained in:
Gurchetan Singh 2023-11-07 15:34:43 -08:00 • committed by Marge Bot
parent 1b8e1d100e
commit c26f73317b
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/gfxstream/codegen/scripts/cerealgenerator.py
View file

@ -77,6 +77,8 @@ SUPPORTED_FEATURES = [
"VK_KHR_descriptor_update_template",
# see aosp/2736079 + b/268351352
"VK_EXT_swapchain_maintenance1",
"VK_KHR_maintenance5",
"VK_EXT_host_image_copy",
"VK_EXT_image_compression_control",
"VK_EXT_image_compression_control_swapchain",
# VK1.3 extensions: see b/298704840