From c26f73317b407d61ea8dc6c19f4c6d80911ae47d Mon Sep 17 00:00:00 2001 From: Gurchetan Singh Date: Tue, 7 Nov 2023 15:34:43 -0800 Subject: [PATCH] gfxstream: add support for VK_KHR_maintenance5 + VK_EXT_host_image_copy In newer versions of vk.xml, VK_EXT_host_image_copy also provides vkGetImageSubresourceLayout2EXT. Autogen for VK_EXT_host_image_copy fails without VK_KHR_maintainance5. For some reason, onGenCmd(..) for vkGetImageSubresourceLayout2EXT is requires VK_EXT_host_image_copy. This goes back into reg.py in vulkan-docs. Interestingly, the Android's libvulkan doesn't use vkGetImageSubresourceLayout2EXT, nor does it check for VK_EXT_image_compression_control before using it. https://android-review.googlesource.com/c/platform/frameworks/native/+/2016419 Thus, we can have VK_EXT_host_image_copy provide the function. Maybe we can revert this if the function isn't used by libvulkan aswell. Reviewed-by: Aaron Ruby Acked-by: Yonggang Luo Acked-by: Adam Jackson Part-of: --- src/gfxstream/codegen/scripts/cerealgenerator.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gfxstream/codegen/scripts/cerealgenerator.py b/src/gfxstream/codegen/scripts/cerealgenerator.py index 677a80fb477..1b434dbbdc6 100644 --- a/src/gfxstream/codegen/scripts/cerealgenerator.py +++ b/src/gfxstream/codegen/scripts/cerealgenerator.py @@ -77,6 +77,8 @@ SUPPORTED_FEATURES = [ "VK_KHR_descriptor_update_template", # see aosp/2736079 + b/268351352 "VK_EXT_swapchain_maintenance1", + "VK_KHR_maintenance5", + "VK_EXT_host_image_copy", "VK_EXT_image_compression_control", "VK_EXT_image_compression_control_swapchain", # VK1.3 extensions: see b/298704840