fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-04-20 05:40:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nir/opt_sink: do not sink inverse_ballot out of loops

Browse source 
Inverse_ballot result is undefined if the input is not dynamically uniform.
And sinking out of loops might make the input divergent.

Fixes: 18a0ff137f ("nir: sink/move inverse_ballot like moves")

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30906>
(cherry picked from commit 91f8e32a85)
This commit is contained in:
Georg Lehmann 2024-08-28 19:03:53 +02:00 • committed by Eric Engestrom
parent ce70d51e83
commit be004d4797
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1174,7 +1174,7 @@
"description": "nir/opt_sink: do not sink inverse_ballot out of loops",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "18a0ff137ffa38257b3e54b70c5394c7de4c7b3d",
"notes": null

1
src/compiler/nir/nir_opt_sink.c
View file

@ -253,6 +253,7 @@ can_sink_out_of_loop(nir_intrinsic_instr *intrin)
*/
return intrin->intrinsic != nir_intrinsic_load_ubo &&
intrin->intrinsic != nir_intrinsic_load_ubo_vec4 &&
intrin->intrinsic != nir_intrinsic_inverse_ballot &&
intrin->intrinsic != nir_intrinsic_load_ssbo;
}