fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 15:38:09 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

nir/opt_sink: do not sink load_ubo_vec4 out of loops

Browse source 
Same reason as for load_ubo.

Fixes: d199d65c3a ("nir/nir_opt_move,sink: Include load_ubo_vec4 as a load_ubo instr.")

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30906>
(cherry picked from commit 1ec3cc2aed)
This commit is contained in:
Georg Lehmann 2024-08-28 19:01:33 +02:00 • committed by Eric Engestrom
parent 099de7a954
commit ce70d51e83
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1184,7 +1184,7 @@
"description": "nir/opt_sink: do not sink load_ubo_vec4 out of loops",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "d199d65c3af6cc87cd77585b21435ddb5125654d",
"notes": null

1
src/compiler/nir/nir_opt_sink.c
View file

@ -252,6 +252,7 @@ can_sink_out_of_loop(nir_intrinsic_instr *intrin)
* by nir_lower_non_uniform_access.
*/
return intrin->intrinsic != nir_intrinsic_load_ubo &&
intrin->intrinsic != nir_intrinsic_load_ubo_vec4 &&
intrin->intrinsic != nir_intrinsic_load_ssbo;
}