fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 11:00:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

freedreno: Fix internal VBO reference leak

Browse source 
It appears that this extra ref is no longer needed.  And not dropped
anywhere.

Fixes: b3133e250e ("gallium: add pipe_context::resource_release to eliminate buffer refcounting")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14315
Signed-off-by: Rob Clark <rob.clark@oss.qualcomm.com>
(cherry picked from commit cccdbbc360)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38803>
This commit is contained in:
Rob Clark 2025-11-24 14:23:10 -08:00 • committed by Dylan Baker
parent e32d0815af
commit bbbee1f85d
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2774,7 +2774,7 @@
"description": "freedreno: Fix internal VBO reference leak",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "b3133e250e1c40496d98c4ba52386b7ae423d194",
"notes": null

1
src/gallium/drivers/freedreno/freedreno_blitter.c
View file

@ -322,7 +322,6 @@ fd_blitter_clear(struct pipe_context *pctx, unsigned buffers,
pctx->set_viewport_states(pctx, 0, 1, &vp);
pctx->bind_vertex_elements_state(pctx, ctx->solid_vbuf_state.vtx);
pipe_reference(NULL, &ctx->solid_vbuf_state.vertexbuf.vb[0].buffer.resource->reference);
pctx->set_vertex_buffers(pctx, 1, &ctx->solid_vbuf_state.vertexbuf.vb[0]);
pctx->set_stream_output_targets(pctx, 0, NULL, NULL, 0);