From bbbee1f85d4cafefbe53e11a5eaa384aef03cbdf Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Mon, 24 Nov 2025 14:23:10 -0800 Subject: [PATCH] freedreno: Fix internal VBO reference leak It appears that this extra ref is no longer needed. And not dropped anywhere. Fixes: b3133e250e1c ("gallium: add pipe_context::resource_release to eliminate buffer refcounting") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14315 Signed-off-by: Rob Clark (cherry picked from commit cccdbbc3605ad89ebc43efd1ab9703ca0f0dba67) Part-of: --- .pick_status.json | 2 +- src/gallium/drivers/freedreno/freedreno_blitter.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 80e12349a2f..ba30854b76d 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -2774,7 +2774,7 @@ "description": "freedreno: Fix internal VBO reference leak", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "b3133e250e1c40496d98c4ba52386b7ae423d194", "notes": null diff --git a/src/gallium/drivers/freedreno/freedreno_blitter.c b/src/gallium/drivers/freedreno/freedreno_blitter.c index f67620a1db7..6366646647a 100644 --- a/src/gallium/drivers/freedreno/freedreno_blitter.c +++ b/src/gallium/drivers/freedreno/freedreno_blitter.c @@ -322,7 +322,6 @@ fd_blitter_clear(struct pipe_context *pctx, unsigned buffers, pctx->set_viewport_states(pctx, 0, 1, &vp); pctx->bind_vertex_elements_state(pctx, ctx->solid_vbuf_state.vtx); - pipe_reference(NULL, &ctx->solid_vbuf_state.vertexbuf.vb[0].buffer.resource->reference); pctx->set_vertex_buffers(pctx, 1, &ctx->solid_vbuf_state.vertexbuf.vb[0]); pctx->set_stream_output_targets(pctx, 0, NULL, NULL, 0);