fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 11:08:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

intel: Remove the texture_tiling driconf option.

Browse source 
This option can force textures to be untiled.  However, on Gen6+, depth
buffers must be Y-tiled.  MSAA buffers also must be Y-tiled.  So setting
this option on even a trivial application like glxgears causes assertion
failures in a debug build, and likely GPU hangs in a release build.

It's just giving users a license to shoot themselves in the foot.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
This commit is contained in:
Kenneth Graunke 2013-04-08 19:39:20 -07:00
parent 55ecc448b9
commit b76539aabe
4 changed files with 1 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/mesa/drivers/dri/intel/intel_context.c
View file

@ -811,8 +811,6 @@ intelInitContext(struct intel_context *intel,
intel_fbo_init(intel);
intel->use_texture_tiling = driQueryOptionb(&intel->optionCache,
"texture_tiling");
intel->use_early_z = driQueryOptionb(&intel->optionCache, "early_z");
if (!driQueryOptionb(&intel->optionCache, "hiz")) {

1
src/mesa/drivers/dri/intel/intel_context.h
View file

@ -343,7 +343,6 @@ struct intel_context
*/
bool is_front_buffer_reading;
bool use_texture_tiling;
bool use_early_z;
int driFd;

3
src/mesa/drivers/dri/intel/intel_mipmap_tree.c
View file

@ -316,9 +316,6 @@ intel_miptree_choose_tiling(struct intel_context *intel,
return I915_TILING_NONE;
}
if (!intel->use_texture_tiling)
return I915_TILING_NONE;
if (force_y_tiling)
return I915_TILING_Y;

6
src/mesa/drivers/dri/intel/intel_screen.c
View file

@ -55,10 +55,6 @@ PUBLIC const char __driConfigOptions[] =
DRI_CONF_DESC_END
DRI_CONF_OPT_END
DRI_CONF_OPT_BEGIN(texture_tiling, bool, true)
DRI_CONF_DESC(en, "Enable texture tiling")
DRI_CONF_OPT_END
DRI_CONF_OPT_BEGIN(hiz, bool, true)
DRI_CONF_DESC(en, "Enable Hierarchical Z on gen6+")
DRI_CONF_OPT_END
@ -95,7 +91,7 @@ PUBLIC const char __driConfigOptions[] =
DRI_CONF_SECTION_END
DRI_CONF_END;
const GLuint __driNConfigOptions = 17;
const GLuint __driNConfigOptions = 16;
#include "intel_batchbuffer.h"
#include "intel_buffers.h"