fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-28 23:20:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

glsl: allow invariant on fragment shader outputs.

Browse source 
From page 27 (page 33 of the PDF) of the GLSL 1.20 spec:

    " Only variables output from a vertex shader can be candidates for
      invariance."

But this later changes to:

From page 37 (page 43 of the PDF) of the GLSL 1.30 spec:

    " Only variables output from a shader can be candidates for
      invariance."

We can also find:

From page 37 (page 43 of the PDF) of the GLSL 1.30 spec:

    " Initially, by default, all output variables are allowed to be
      variant. To force all output variables to be invariant, use the
      pragma

        #pragma STDGL invariant(all)

      before all declarations in a shader. If this pragma is used after
      the declaration of any variables or functions, then the set of
      outputs that behave as invariant is undefined. It is an error to
      use this pragma in a fragment shader."

But this needs to be corrected and it is being addressed at:
https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16140

Fixes GL45-CTS.shading_language_420pack.qualifier_order.

Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Andres Gomez <agomez@igalia.com>
This commit is contained in:
Dave Airlie 2016-05-23 14:18:03 +10:00 • committed by Andres Gomez
parent f562b13bc7
commit ab8ea1b3d4
1 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/compiler/glsl/ast_to_hir.cpp
View file

@ -2634,6 +2634,28 @@ is_varying_var(ir_variable *var, gl_shader_stage target)
}
}
static bool
is_allowed_invariant(ir_variable *var, struct _mesa_glsl_parse_state *state)
{
if (is_varying_var(var, state->stage))
return true;
/* From Section 4.6.1 ("The Invariant Qualifier") GLSL 1.20 spec:
* "Only variables output from a vertex shader can be candidates
* for invariance".
*/
if (!state->is_version(130, 0))
return false;
/*
* Later specs remove this language - so allowed invariant
* on fragment shader outputs as well.
*/
if (state->stage == MESA_SHADER_FRAGMENT &&
var->data.mode == ir_var_shader_out)
return true;
return false;
}
/**
* Matrix layout qualifiers are only allowed on certain types
@ -4495,7 +4517,7 @@ ast_declarator_list::hir(exec_list *instructions,
_mesa_glsl_error(& loc, state,
"undeclared variable `%s' cannot be marked "
"invariant", decl->identifier);
} else if (!is_varying_var(earlier, state->stage)) {
} else if (!is_allowed_invariant(earlier, state)) {
_mesa_glsl_error(&loc, state,
"`%s' cannot be marked invariant; interfaces between "
"shader stages only.", decl->identifier);
@ -4791,7 +4813,7 @@ ast_declarator_list::hir(exec_list *instructions,
}
if (this->type->qualifier.flags.q.invariant) {
if (!is_varying_var(var, state->stage)) {
if (!is_allowed_invariant(var, state)) {
_mesa_glsl_error(&loc, state,
"`%s' cannot be marked invariant; interfaces between "
"shader stages only", var->name);