jay: drop a bunch of stale TODO and XXX

These are either done, or never going to be done, or otherwise stale or
silly or unnecessary. Drop a bunch.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41215>
This commit is contained in:
Alyssa Rosenzweig 2026-04-21 13:27:04 -04:00 committed by Marge Bot
parent 70d09d97ef
commit ab87a035c9
6 changed files with 4 additions and 13 deletions

View file

@ -417,6 +417,3 @@ jay_assign_flags(jay_shader *s)
copyprop(f);
}
}
/* TODO: revisit
* dEQP-GLES3.functional.shaders.arrays.compare.equal_highp_vec4_highp_vec4_vertex
*/

View file

@ -2450,7 +2450,6 @@ setup_fragment_payload(struct nir_to_jay_state *nj, struct payload_builder *p)
}
}
/* XXX: I do not love this */
if (BITSET_TEST(nj->nir->info.system_values_read, SYSTEM_VALUE_FRAG_COORD)) {
jay_def t = jay_alloc_def(&nj->bld, GPR, 1);
jay_def lo = jay_extract_range(nj->payload.u0, 10, 4);

View file

@ -834,7 +834,6 @@ jay_grf_per_gpr(jay_shader *s)
static inline unsigned
jay_phys_flag_per_virt(jay_shader *s)
{
/* TODO: Check if this holds on older platforms */
return jay_grf_per_gpr(s);
}
@ -900,7 +899,7 @@ jay_dst_alignment(jay_shader *shader, const jay_inst *I)
* Register Regioning patterns where register data bit locations are
* changed between source and destination are not supported when an
* accumulator is used as an implicit source or an explicit source in an
* instruction. (TODO)
* instruction.
*/
if (I->dst.file == UGPR &&
(I->op == JAY_OPCODE_SEND || I->op == JAY_OPCODE_MUL_32)) {

View file

@ -131,7 +131,7 @@ struct swsb_state {
static enum tgl_pipe
inst_exec_pipe(const struct intel_device_info *devinfo, jay_inst *I)
{
if (I->op == JAY_OPCODE_SEND || jay_op_is_control_flow(I->op) /* XXX*/) {
if (I->op == JAY_OPCODE_SEND || jay_op_is_control_flow(I->op)) {
return TGL_PIPE_NONE;
} else if (I->op == JAY_OPCODE_MATH) {
return TGL_PIPE_MATH;

View file

@ -44,11 +44,7 @@ max_simd_width(const jay_shader *shader, const jay_inst *I)
}
}
} else {
/* TODO: Do we ever split SENDs? ..Can we even split SENDs given we don't
* have stride control? How is this supposed to work?
*
* XXX
*/
/* TODO: Split SENDs, needs RA work */
}
return 32;

View file

@ -26,7 +26,7 @@ struct regfile {
static uint32_t *
reg(struct regfile *rf, enum jay_file file, uint32_t reg)
{
/* FLAG and UFLAG share their registers. TODO: Rework? */
/* FLAG and UFLAG share their registers */
if (file == UFLAG) {
file = FLAG;
}