From ab87a035c945af72642fc8fa395a3c52e400bf93 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Tue, 21 Apr 2026 13:27:04 -0400 Subject: [PATCH] jay: drop a bunch of stale TODO and XXX These are either done, or never going to be done, or otherwise stale or silly or unnecessary. Drop a bunch. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/intel/compiler/jay/jay_assign_flags.c | 3 --- src/intel/compiler/jay/jay_from_nir.c | 1 - src/intel/compiler/jay/jay_ir.h | 3 +-- src/intel/compiler/jay/jay_lower_scoreboard.c | 2 +- src/intel/compiler/jay/jay_simd_width.c | 6 +----- src/intel/compiler/jay/jay_validate_ra.c | 2 +- 6 files changed, 4 insertions(+), 13 deletions(-) diff --git a/src/intel/compiler/jay/jay_assign_flags.c b/src/intel/compiler/jay/jay_assign_flags.c index 827bc89bb01..6c189f1ea99 100644 --- a/src/intel/compiler/jay/jay_assign_flags.c +++ b/src/intel/compiler/jay/jay_assign_flags.c @@ -417,6 +417,3 @@ jay_assign_flags(jay_shader *s) copyprop(f); } } -/* TODO: revisit - * dEQP-GLES3.functional.shaders.arrays.compare.equal_highp_vec4_highp_vec4_vertex - */ diff --git a/src/intel/compiler/jay/jay_from_nir.c b/src/intel/compiler/jay/jay_from_nir.c index 13b0d0f7ce5..df5b90b7b05 100644 --- a/src/intel/compiler/jay/jay_from_nir.c +++ b/src/intel/compiler/jay/jay_from_nir.c @@ -2450,7 +2450,6 @@ setup_fragment_payload(struct nir_to_jay_state *nj, struct payload_builder *p) } } - /* XXX: I do not love this */ if (BITSET_TEST(nj->nir->info.system_values_read, SYSTEM_VALUE_FRAG_COORD)) { jay_def t = jay_alloc_def(&nj->bld, GPR, 1); jay_def lo = jay_extract_range(nj->payload.u0, 10, 4); diff --git a/src/intel/compiler/jay/jay_ir.h b/src/intel/compiler/jay/jay_ir.h index f65cb1537a4..b06065bfc50 100644 --- a/src/intel/compiler/jay/jay_ir.h +++ b/src/intel/compiler/jay/jay_ir.h @@ -834,7 +834,6 @@ jay_grf_per_gpr(jay_shader *s) static inline unsigned jay_phys_flag_per_virt(jay_shader *s) { - /* TODO: Check if this holds on older platforms */ return jay_grf_per_gpr(s); } @@ -900,7 +899,7 @@ jay_dst_alignment(jay_shader *shader, const jay_inst *I) * Register Regioning patterns where register data bit locations are * changed between source and destination are not supported when an * accumulator is used as an implicit source or an explicit source in an - * instruction. (TODO) + * instruction. */ if (I->dst.file == UGPR && (I->op == JAY_OPCODE_SEND || I->op == JAY_OPCODE_MUL_32)) { diff --git a/src/intel/compiler/jay/jay_lower_scoreboard.c b/src/intel/compiler/jay/jay_lower_scoreboard.c index c0a5b85e1c1..872de2310e1 100644 --- a/src/intel/compiler/jay/jay_lower_scoreboard.c +++ b/src/intel/compiler/jay/jay_lower_scoreboard.c @@ -131,7 +131,7 @@ struct swsb_state { static enum tgl_pipe inst_exec_pipe(const struct intel_device_info *devinfo, jay_inst *I) { - if (I->op == JAY_OPCODE_SEND || jay_op_is_control_flow(I->op) /* XXX*/) { + if (I->op == JAY_OPCODE_SEND || jay_op_is_control_flow(I->op)) { return TGL_PIPE_NONE; } else if (I->op == JAY_OPCODE_MATH) { return TGL_PIPE_MATH; diff --git a/src/intel/compiler/jay/jay_simd_width.c b/src/intel/compiler/jay/jay_simd_width.c index 0c0fcfdb77c..5be6cf4961d 100644 --- a/src/intel/compiler/jay/jay_simd_width.c +++ b/src/intel/compiler/jay/jay_simd_width.c @@ -44,11 +44,7 @@ max_simd_width(const jay_shader *shader, const jay_inst *I) } } } else { - /* TODO: Do we ever split SENDs? ..Can we even split SENDs given we don't - * have stride control? How is this supposed to work? - * - * XXX - */ + /* TODO: Split SENDs, needs RA work */ } return 32; diff --git a/src/intel/compiler/jay/jay_validate_ra.c b/src/intel/compiler/jay/jay_validate_ra.c index 01de82566cf..263b8deec2b 100644 --- a/src/intel/compiler/jay/jay_validate_ra.c +++ b/src/intel/compiler/jay/jay_validate_ra.c @@ -26,7 +26,7 @@ struct regfile { static uint32_t * reg(struct regfile *rf, enum jay_file file, uint32_t reg) { - /* FLAG and UFLAG share their registers. TODO: Rework? */ + /* FLAG and UFLAG share their registers */ if (file == UFLAG) { file = FLAG; }