fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-16 02:10:25 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

intel/isl: Use 1x Ys/Yf swizzle for IMS layout

Browse source 
From the ICL PRMs Volume 5: Memory Data Formats, "Compressed
Multisampled Surfaces":

   Tiling for CMS and UMS Surfaces

   Multisampled CMS and UMS use a modified table from
   non-mulitsampled 2D surfaces.

   [...]

   TileYS: In addition to u and v, the sample slice index “ss” is
   included in the address swizzling according to the following
   table.

   [...]

   TileYF: In addition to u and v, the sample slice index “ss” is
   included in the address swizzling according to the following
   table.

For depth/stencil surfaces with Yf/Ys tiling, don't use the MSAA
swizzles.

With the driver modified forced to prefer Ys/Yf for depth buffers, this
fixes 14 failing tests in the VK CTS group:

   dEQP-VK.pipeline.monolithic.multisample.misc.clear*16x*

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38063>
This commit is contained in:
Nanley Chery 2025-10-15 09:01:21 -04:00 • committed by Marge Bot
parent 33a8b6b765
commit aa09fc3de0
1 changed files with 28 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/intel/isl/isl.c
View file

@ -1290,18 +1290,43 @@ isl_tiling_get_info(enum isl_tiling tiling,
};
#undef YS_OR_YF
/* From the ICL PRMs Volume 5: Memory Data Formats, "Compressed
* Multisampled Surfaces":
*
* Tiling for CMS and UMS Surfaces
*
* Multisampled CMS and UMS use a modified table from
* non-mulitsampled 2D surfaces.
*
* [...]
*
* TileYS: In addition to u and v, the sample slice index “ss” is
* included in the address swizzling according to the following
* table.
*
* [...]
*
* TileYF: In addition to u and v, the sample slice index “ss” is
* included in the address swizzling according to the following
* table.
*
* IMS surfaces don't use the MSAA swizzles for Yf/Ys.
*/
const uint32_t sample_idx =
(msaa_layout == ISL_MSAA_LAYOUT_INTERLEAVED) ? 0 :
(ffs(samples) - 1);
switch (format_bpb) {
case 128:
case 64:
SET_SWIZ(_128_64bpp_swiz[ffs(samples) - 1], tiling_bits);
SET_SWIZ(_128_64bpp_swiz[sample_idx], tiling_bits);
break;
case 32:
case 16:
SET_SWIZ(_32_16bpp_swiz[ffs(samples) - 1], tiling_bits);
SET_SWIZ(_32_16bpp_swiz[sample_idx], tiling_bits);
break;
case 8:
SET_SWIZ(_8bpp_swiz[ffs(samples) - 1], tiling_bits);
SET_SWIZ(_8bpp_swiz[sample_idx], tiling_bits);
break;
default:
UNREACHABLE("Unsupported format size");