broadcom/compiler: stop moving UBO loads before NIR scheduling

This doesn't have any significant impact shader-db stats and would
reduce our capacity to hide latency from the loads, so it is probably
undesirable:

total instructions in shared programs: 12663189 -> 12663186 (<.01%)
instructions in affected programs: 4222 -> 4219 (-0.07%)
helped: 9
HURT: 4

total uniforms in shared programs: 3711624 -> 3711629 (<.01%)
uniforms in affected programs: 186 -> 191 (2.69%)
helped: 0
HURT: 2

total max-temps in shared programs: 2138822 -> 2138857 (<.01%)
max-temps in affected programs: 569 -> 604 (6.15%)
helped: 1
HURT: 9

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15276>
This commit is contained in:
Iago Toral Quiroga 2022-03-02 11:10:39 +01:00 committed by Marge Bot
parent bf7777a5d4
commit 9ef499b315

View file

@ -2160,8 +2160,6 @@ v3d_optimize_nir(struct v3d_compile *c, struct nir_shader *s)
nir_move_const_undef | nir_move_comparisons | nir_move_copies |
nir_move_load_ubo | nir_move_load_uniform;
NIR_PASS(progress, s, nir_opt_sink, sink_opts);
NIR_PASS(progress, s, nir_opt_move, nir_move_load_ubo);
}
static int