From 9ef499b315392d5c1ac853917b7c7eaaa098ad4a Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Wed, 2 Mar 2022 11:10:39 +0100 Subject: [PATCH] broadcom/compiler: stop moving UBO loads before NIR scheduling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This doesn't have any significant impact shader-db stats and would reduce our capacity to hide latency from the loads, so it is probably undesirable: total instructions in shared programs: 12663189 -> 12663186 (<.01%) instructions in affected programs: 4222 -> 4219 (-0.07%) helped: 9 HURT: 4 total uniforms in shared programs: 3711624 -> 3711629 (<.01%) uniforms in affected programs: 186 -> 191 (2.69%) helped: 0 HURT: 2 total max-temps in shared programs: 2138822 -> 2138857 (<.01%) max-temps in affected programs: 569 -> 604 (6.15%) helped: 1 HURT: 9 Reviewed-by: Alejandro Piñeiro Part-of: --- src/broadcom/compiler/nir_to_vir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/broadcom/compiler/nir_to_vir.c b/src/broadcom/compiler/nir_to_vir.c index 8dcad1a5364..28559048468 100644 --- a/src/broadcom/compiler/nir_to_vir.c +++ b/src/broadcom/compiler/nir_to_vir.c @@ -2160,8 +2160,6 @@ v3d_optimize_nir(struct v3d_compile *c, struct nir_shader *s) nir_move_const_undef | nir_move_comparisons | nir_move_copies | nir_move_load_ubo | nir_move_load_uniform; NIR_PASS(progress, s, nir_opt_sink, sink_opts); - - NIR_PASS(progress, s, nir_opt_move, nir_move_load_ubo); } static int