anv: vkCmdTraceRays* are not covered by conditional rendering
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
macOS-CI / macOS-CI (xlib) (push) Waiting to run

The spec says:
  Certain rendering commands can be executed conditionally based on a
  value in buffer memory. These rendering commands are limited to
  drawing commands, dispatching commands, and clearing attachments with
  vkCmdClearAttachments within a conditional rendering block which is
  defined by commands vkCmdBeginConditionalRenderingEXT and
  vkCmdEndConditionalRenderingEXT. Other rendering commands remain
  unaffected by conditional rendering.

It would seem that vkCmdTraceRays* are not covered by that.

Fixes new tests dEQP-VK.conditional_rendering.conditional_ignore.trace_rays*

Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34864>
This commit is contained in:
Iván Briano 2025-05-07 14:05:07 -07:00 committed by Marge Bot
parent bdadd1aa68
commit 99405647a4

View file

@ -1435,7 +1435,7 @@ cmd_buffer_trace_rays(struct anv_cmd_buffer *cmd_buffer,
GENX(COMPUTE_WALKER_length),
GENX(COMPUTE_WALKER),
.IndirectParameterEnable = params->is_launch_size_indirect,
.PredicateEnable = cmd_buffer->state.conditional_render_enabled,
.PredicateEnable = false,
.body = body,
);