From 99405647a436266e012afed5ad74e93a661259ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Briano?= Date: Wed, 7 May 2025 14:05:07 -0700 Subject: [PATCH] anv: vkCmdTraceRays* are not covered by conditional rendering MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The spec says: Certain rendering commands can be executed conditionally based on a value in buffer memory. These rendering commands are limited to drawing commands, dispatching commands, and clearing attachments with vkCmdClearAttachments within a conditional rendering block which is defined by commands vkCmdBeginConditionalRenderingEXT and vkCmdEndConditionalRenderingEXT. Other rendering commands remain unaffected by conditional rendering. It would seem that vkCmdTraceRays* are not covered by that. Fixes new tests dEQP-VK.conditional_rendering.conditional_ignore.trace_rays* Reviewed-by: Tapani Pälli Reviewed-by: Lionel Landwerlin Part-of: --- src/intel/vulkan/genX_cmd_compute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/genX_cmd_compute.c b/src/intel/vulkan/genX_cmd_compute.c index d8ea87bbfbf..d3022abcda8 100644 --- a/src/intel/vulkan/genX_cmd_compute.c +++ b/src/intel/vulkan/genX_cmd_compute.c @@ -1435,7 +1435,7 @@ cmd_buffer_trace_rays(struct anv_cmd_buffer *cmd_buffer, GENX(COMPUTE_WALKER_length), GENX(COMPUTE_WALKER), .IndirectParameterEnable = params->is_launch_size_indirect, - .PredicateEnable = cmd_buffer->state.conditional_render_enabled, + .PredicateEnable = false, .body = body, );