fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 04:58:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

nir: Consider if uses in nir_def_all_uses_*

Browse source 
They check for if uses and want to return false but nir_foreach_use()
means the if uses are never seen.

Cc: mesa-stable
Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Mel Henning <mhenning@darkrefraction.com>
(cherry picked from commit 3f870d62b0)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40752>
This commit is contained in:
Faith Ekstrand 2025-09-19 12:22:03 -04:00 • committed by Eric Engestrom
parent 6462dac37d
commit 97105a1526
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -3424,7 +3424,7 @@
"description": "nir: Consider if uses in nir_def_all_uses_*",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

4
src/compiler/nir/nir.c
View file

@ -1858,7 +1858,7 @@ nir_def_components_read(const nir_def *def)
bool
nir_def_all_uses_are_fsat(const nir_def *def)
{
nir_foreach_use(src, def) {
nir_foreach_use_including_if(src, def) {
if (nir_src_is_if(src))
return false;
@ -1877,7 +1877,7 @@ nir_def_all_uses_are_fsat(const nir_def *def)
bool
nir_def_all_uses_ignore_sign_bit(const nir_def *def)
{
nir_foreach_use(use, def) {
nir_foreach_use_including_if(use, def) {
if (nir_src_is_if(use))
return false;
nir_instr *instr = nir_src_parent_instr(use);