fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 11:18:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

freedreno: Fix leak of shader binary on disk cache hits.

Browse source 
It's supposed to be ralloced -- there's not even a shader variant destroy
function for freeing, just ralloc_free() on the ir3_shader_variant or the
parent ir3_shader when you're done!

Fixes: f97acb4bb4 ("freedreno/ir3: disk-cache support")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5810>
(cherry picked from commit 433841d9eb)
This commit is contained in:
Eric Anholt 2020-08-03 19:23:34 -07:00 • committed by Dylan Baker
parent 6f379548a9
commit 9020df131f
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1858,7 +1858,7 @@
"description": "freedreno: Fix leak of shader binary on disk cache hits.",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "f97acb4bb4b18f127b62aa8eeb57cdf3d8fe3aa2"
},

2
src/freedreno/ir3/ir3_disk_cache.c
View file

@ -126,7 +126,7 @@ retrieve_variant(struct blob_reader *blob, struct ir3_shader_variant *v)
* pointers need special handling:
*/
v->bin = malloc(4 * v->info.sizedwords);
v->bin = rzalloc_size(v, 4 * v->info.sizedwords);
blob_copy_bytes(blob, v->bin, 4 * v->info.sizedwords);
if (!v->binning_pass) {