fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-02 11:00:27 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radv: Fix TCS -> TES I/O linking typo of VARYING_SLOT vs. BIT.

Browse source 
In these bitwise expressions, VARYING_BIT_* should be used,
but the code mistakenly used VARYING_SLOT_* which is wrong.

Fixes: 0e481a4adc
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29327>
(cherry picked from commit 3963e4b53a)
This commit is contained in:
Timur Kristóf 2024-05-22 15:24:53 +02:00 • committed by Eric Engestrom
parent fd3f9a152c
commit 83fc0888b5
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -14,7 +14,7 @@
"description": "radv: Fix TCS -> TES I/O linking typo of VARYING_SLOT vs. BIT.",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "0e481a4adcd8006256c27d100a0a0f0c01a94171",
"notes": null

2
src/amd/vulkan/radv_pipeline_graphics.c
View file

@ -1421,7 +1421,7 @@ radv_link_tcs(const struct radv_device *device, struct radv_shader_stage *tcs_st
/* Count the number of per-vertex output slots we need to reserve for the TCS and TES. */
const uint64_t nir_mask = tcs_stage->nir->info.outputs_written & tes_stage->nir->info.inputs_read &
~(VARYING_SLOT_TESS_LEVEL_OUTER | VARYING_SLOT_TESS_LEVEL_INNER);
~(VARYING_BIT_TESS_LEVEL_OUTER | VARYING_BIT_TESS_LEVEL_INNER);
const uint64_t io_mask = radv_gather_unlinked_io_mask(nir_mask);
const unsigned num_reserved_outputs = util_last_bit64(io_mask);