fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 07:28:11 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

radv: remove radv_disable_dedicated_sparse_queue completely

Browse source 
This drirc workaround is probably not useful since RADV allows SPARSE
on all queues.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35023>
This commit is contained in:
Samuel Pitoiset 2025-05-20 08:41:56 +02:00 • committed by Marge Bot
parent 4cc9bb4532
commit 817f7f1bb2
5 changed files with 1 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/amd/vulkan/radv_instance.c
View file

@ -187,7 +187,6 @@ static const driOptionDescription radv_dri_options[] = {
DRI_CONF_RADV_TEX_NON_UNIFORM(false)
DRI_CONF_RADV_FLUSH_BEFORE_TIMESTAMP_WRITE(false)
DRI_CONF_RADV_RT_WAVE64(false)
DRI_CONF_RADV_DISABLE_DEDICATED_SPARSE_QUEUE(false)
DRI_CONF_RADV_OVERRIDE_GRAPHICS_SHADER_VERSION(0)
DRI_CONF_RADV_OVERRIDE_COMPUTE_SHADER_VERSION(0)
DRI_CONF_RADV_OVERRIDE_RAY_TRACING_SHADER_VERSION(0)
@ -270,8 +269,6 @@ radv_init_dri_options(struct radv_instance *instance)
if (driQueryOptionb(&instance->drirc.options, "radv_rt_wave64"))
instance->perftest_flags |= RADV_PERFTEST_RT_WAVE_64;
instance->drirc.disable_dedicated_sparse_queue = driQueryOptionb(&instance->drirc.options, "radv_disable_dedicated_sparse_queue");
instance->drirc.override_graphics_shader_version =
driQueryOptioni(&instance->drirc.options, "radv_override_graphics_shader_version");
instance->drirc.override_compute_shader_version =

1
src/amd/vulkan/radv_instance.h
View file

@ -63,7 +63,6 @@ struct radv_instance {
bool tex_non_uniform;
bool ssbo_non_uniform;
bool flush_before_timestamp_write;
bool disable_dedicated_sparse_queue;
bool clear_lds;
bool enable_khr_present_wait;
bool report_llvm9_version_string;

4
src/amd/vulkan/radv_physical_device.h
View file

@ -205,11 +205,9 @@ radv_physical_device_instance(const struct radv_physical_device *pdev)
static inline bool
radv_dedicated_sparse_queue_enabled(const struct radv_physical_device *pdev)
{
const struct radv_instance *instance = radv_physical_device_instance(pdev);
/* Dedicated sparse queue requires VK_QUEUE_SUBMIT_MODE_THREADED, which is incompatible with
* VK_DEVICE_TIMELINE_MODE_EMULATED. */
return pdev->info.has_timeline_syncobj && !instance->drirc.disable_dedicated_sparse_queue;
return pdev->info.has_timeline_syncobj;
}
static inline bool

13
src/amd/vulkan/tests/drirc.cpp
View file

@ -9,19 +9,6 @@
class drirc : public radv_test {};
TEST_F(drirc, disable_dedicated_sparse_queue)
{
create_device();
EXPECT_TRUE(is_dedicated_sparse_queue_enabled());
destroy_device();
add_envvar("radv_disable_dedicated_sparse_queue", "true");
create_device();
EXPECT_FALSE(is_dedicated_sparse_queue_enabled());
destroy_device();
}
TEST_F(drirc, override_uniform_offset_alignment)
{
create_device();

4
src/util/driconf.h
View file

@ -751,10 +751,6 @@
DRI_CONF_OPT_B(radv_rt_wave64, def, \
"Force wave64 in RT shaders")
#define DRI_CONF_RADV_DISABLE_DEDICATED_SPARSE_QUEUE(def) \
DRI_CONF_OPT_B(radv_disable_dedicated_sparse_queue, def, \
"Disables the dedicated sparse queue. This replaces radv_legacy_sparse_binding as a compatible drirc workaround for games that might not expect a separate SPARSE queue")
/**
* Overrides for forcing re-compilation of pipelines when RADV_BUILD_ID_OVERRIDE is enabled.
* These need to be bumped every time a compiler bugfix is backported (up to 8 shader