fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/va: Use preload abstraction for blend shader regs

Browse source 
A couple of preloads were missed when implementing the preload register
abstraction.

This fix is not required prior to v15, but marking it as a bug fix for
consistency.

Fixes: 1f0370616a ("pan: Centralize preload registers")
This commit is contained in:
Lars-Ivar Hesselberg Simonsen 2026-04-20 15:03:01 +02:00
parent 2f6a4e7692
commit 769eddfeca
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/panfrost/compiler/bifrost/bifrost_compile.c
View file

@ -4698,7 +4698,7 @@ bi_compile_variant(nir_shader *nir,
uint64_t preload = first_block->reg_live_in;
/* If multisampling is used with a blend shader, the blend shader needs
* to access the sample coverage mask in r60 and the sample ID in r61.
* to access the sample coverage mask and the sample ID.
* Blend shaders run in the same context as fragment shaders, so if a
* blend shader could run, we need to preload these registers
* conservatively. There is believed to be little cost to doing so, so
@ -4709,7 +4709,10 @@ bi_compile_variant(nir_shader *nir,
* driver. We could unify the paths if the cost is acceptable.
*/
if (nir->info.stage == MESA_SHADER_FRAGMENT && ctx->arch >= 9)
preload |= BITFIELD64_BIT(60) | BITFIELD64_BIT(61);
preload |=
BITFIELD64_BIT(
bi_preload_reg(BI_PRELOAD_CUMULATIVE_COVERAGE, ctx->arch)) |
BITFIELD64_BIT(bi_preload_reg(BI_PRELOAD_SAMPLE_ID, ctx->arch));
info->ubo_mask |= ctx->ubo_mask;
info->tls_size = MAX2(info->tls_size, ctx->info.tls_size);