fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 20:28:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

svga: check to avoid writing beyond end of constant buffer

Browse source 
See bug 688394
This commit is contained in:
Brian Paul 2011-06-20 11:07:57 -06:00
parent 974b6413f4
commit 73e840ab7d
1 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/gallium/drivers/svga/svga_state_constants.c
View file

@ -107,7 +107,29 @@ static enum pipe_error emit_const_range( struct svga_context *svga,
unsigned i, j;
enum pipe_error ret;
assert(offset + count < CB_MAX);
#ifdef DEBUG
if (offset + count > CB_MAX) {
debug_printf("svga: too many constants (offset + count = %u)\n",
offset + count);
}
#endif
if (offset > CB_MAX) {
/* This isn't OK, but if we propagate an error all the way up we'll
* just get into more trouble.
* XXX note that offset is always zero at this time so this is moot.
*/
return PIPE_OK;
}
if (offset + count > CB_MAX) {
/* Just drop the extra constants for now.
* Ideally we should not have allowed the app to create a shader
* that exceeds our constant buffer size but there's no way to
* express that in gallium at this time.
*/
count = CB_MAX - offset;
}
i = 0;
while (i < count) {