fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 18:08:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

aco/insert_fp_mode: don't skip setting round for fract

Browse source 
fract(-FLT_MIN) is < 1.0 with rtz but 1.0 with rtne.

Fixes: 7212a75c5e ("aco/insert_fp_mode: exclude some instructions that will never round")

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
(cherry picked from commit 8f4de30d05)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/40359>
This commit is contained in:
Georg Lehmann 2026-02-24 20:15:44 +01:00 • committed by Eric Engestrom
parent f1a64582dd
commit 6c7f739b9d
2 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -5824,7 +5824,7 @@
"description": "aco/insert_fp_mode: don't skip setting round for fract",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "7212a75c5ef38268b3b9ee332fce80043a4e4809",
"notes": null

3
src/amd/compiler/aco_insert_fp_mode.cpp
View file

@ -233,9 +233,6 @@ instr_ignores_round_mode(const Instruction* instr)
case aco_opcode::v_rndne_f64:
case aco_opcode::v_rndne_f32:
case aco_opcode::v_rndne_f16:
case aco_opcode::v_fract_f64:
case aco_opcode::v_fract_f32:
case aco_opcode::v_fract_f16:
case aco_opcode::s_min_f32:
case aco_opcode::s_min_f16:
case aco_opcode::s_max_f32: