From 6c7f739b9d5018eb4c0baa62fafc58041aaed371 Mon Sep 17 00:00:00 2001 From: Georg Lehmann Date: Tue, 24 Feb 2026 20:15:44 +0100 Subject: [PATCH] aco/insert_fp_mode: don't skip setting round for fract MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fract(-FLT_MIN) is < 1.0 with rtz but 1.0 with rtne. Fixes: 7212a75c5ef ("aco/insert_fp_mode: exclude some instructions that will never round") Reviewed-by: Daniel Schürmann (cherry picked from commit 8f4de30d0581ed9bc6c289cc62eafc2253ef63a0) Part-of: --- .pick_status.json | 2 +- src/amd/compiler/aco_insert_fp_mode.cpp | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 9d8ee416191..16eb7fc1775 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -5824,7 +5824,7 @@ "description": "aco/insert_fp_mode: don't skip setting round for fract", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "7212a75c5ef38268b3b9ee332fce80043a4e4809", "notes": null diff --git a/src/amd/compiler/aco_insert_fp_mode.cpp b/src/amd/compiler/aco_insert_fp_mode.cpp index a5609ecace1..10d5ff51c2c 100644 --- a/src/amd/compiler/aco_insert_fp_mode.cpp +++ b/src/amd/compiler/aco_insert_fp_mode.cpp @@ -233,9 +233,6 @@ instr_ignores_round_mode(const Instruction* instr) case aco_opcode::v_rndne_f64: case aco_opcode::v_rndne_f32: case aco_opcode::v_rndne_f16: - case aco_opcode::v_fract_f64: - case aco_opcode::v_fract_f32: - case aco_opcode::v_fract_f16: case aco_opcode::s_min_f32: case aco_opcode::s_min_f16: case aco_opcode::s_max_f32: