fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 13:28:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

intel/clflush: Utilize clflushopt in intel_invalidate_range

Browse source 
On MTL ChromeOS boards, during AI based video conference, we were
observing a lot of overhead from invalidations. Upon debug, it was found
that we were using clflush in this function and that isn't efficient.

With this change, while executing compute workloads like zoo models, we
are getting ~25% performance improvements in a best case scenario.

Rework:
 * Jordan: Call intel_clflushopt_range() rather than
   __builtin_ia32_clflushopt() because intel_mem.c is not compiled
   with -mclflushopt.

Backport-to: 24.1 24.2
Signed-off-by: Sushma Venkatesh Reddy <sushma.venkatesh.reddy@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30238>
(cherry picked from commit 2f6919e6c2)
This commit is contained in:
Sushma Venkatesh Reddy 2024-07-17 18:55:46 -07:00 • committed by Eric Engestrom
parent a381332757
commit 5f8a46c62c
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -214,7 +214,7 @@
"description": "intel/clflush: Utilize clflushopt in intel_invalidate_range",
"nominated": true,
"nomination_type": 4,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

11
src/intel/common/intel_mem.c
View file

@ -78,7 +78,7 @@ intel_invalidate_range(void *start, size_t size)
if (size == 0)
return;
intel_clflush_range(start, size);
intel_flush_range_no_fence(start, size);
/* Modern Atom CPUs (Baytrail+) have issues with clflush serialization,
* where mfence is not a sufficient synchronization barrier. We must
@ -90,6 +90,15 @@ intel_invalidate_range(void *start, size_t size)
* ("drm: Restore double clflush on the last partial cacheline")
* and https://bugs.freedesktop.org/show_bug.cgi?id=92845.
*/
#ifdef HAVE___BUILTIN_IA32_CLFLUSHOPT
/* clflushopt doesn't include an mfence like clflush */
if (util_get_cpu_caps()->has_clflushopt) {
__builtin_ia32_mfence();
intel_clflushopt_range(start + size - 1, 1);
__builtin_ia32_mfence();
return;
}
#endif
__builtin_ia32_clflush(start + size - 1);
__builtin_ia32_mfence();
}