fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-23 22:00:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radv: disable TC-compat HTILE in GENERAL for Detroit: Become Human

Browse source 
The game has invalid usage of render loops and enabling TC-compat
HTILE in GENERAL introduces rendering issues.

Gitlab: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3063
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8359>
This commit is contained in:
Samuel Pitoiset 2021-01-07 08:38:01 +01:00 • committed by Marge Bot
parent 8f9b2afe70
commit 52b6adfbfb
3 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/amd/vulkan/radv_device.c
View file

@ -619,6 +619,14 @@ radv_handle_per_app_options(struct radv_instance *instance,
/* Fix various artifacts in Detroit: Become Human */ /* Fix various artifacts in Detroit: Become Human */
instance->debug_flags |= RADV_DEBUG_ZERO_VRAM | instance->debug_flags |= RADV_DEBUG_ZERO_VRAM |
RADV_DEBUG_DISCARD_TO_DEMOTE; RADV_DEBUG_DISCARD_TO_DEMOTE;
/* Fix rendering issues in Detroit: Become Human
* because the game uses render loops (it
* samples/renders from/to the same depth/stencil
* texture inside the same draw) without input
* attachments and that is invalid Vulkan usage.
*/
instance->disable_tc_compat_htile_in_general = true;
} }
} }

3
src/amd/vulkan/radv_image.c
View file

@ -1841,7 +1841,8 @@ bool radv_layout_is_htile_compressed(const struct radv_device *device,
*/ */
if (radv_image_is_tc_compat_htile(image) && if (radv_image_is_tc_compat_htile(image) &&
queue_mask & (1u << RADV_QUEUE_GENERAL) && queue_mask & (1u << RADV_QUEUE_GENERAL) &&
!in_render_loop) { !in_render_loop &&
!device->instance->disable_tc_compat_htile_in_general) {
/* GFX10+ supports compressed writes to HTILE. */ /* GFX10+ supports compressed writes to HTILE. */
return device->physical_device->rad_info.chip_class >= GFX10 || return device->physical_device->rad_info.chip_class >= GFX10 ||
!(image->usage & VK_IMAGE_USAGE_STORAGE_BIT); !(image->usage & VK_IMAGE_USAGE_STORAGE_BIT);

1
src/amd/vulkan/radv_private.h
View file

@ -360,6 +360,7 @@ struct radv_instance {
* Workarounds for game bugs. * Workarounds for game bugs.
*/ */
bool enable_mrt_output_nan_fixup; bool enable_mrt_output_nan_fixup;
bool disable_tc_compat_htile_in_general;
}; };
VkResult radv_init_wsi(struct radv_physical_device *physical_device); VkResult radv_init_wsi(struct radv_physical_device *physical_device);