fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-30 15:50:32 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

aco: assume sram ecc is enabled on Vega20

Browse source 
There are D16 load issues on Vega20 that are expected if sram ecc is enabled.
It's a professional class chip and I found mentions of it supporting ecc,
so assume it's enabled.

Maybe this could be improved by querying ecc info from the kernel, but
I'm not sure which query should be used.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13189
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12393
Cc: mesa-stable

Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35045>
(cherry picked from commit 0257644130)
This commit is contained in:
Georg Lehmann 2025-05-18 20:36:22 +02:00 • committed by Eric Engestrom
parent 4bd75f552c
commit 4fa2dbdf55
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -224,7 +224,7 @@
"description": "aco: assume sram ecc is enabled on Vega20",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null,
"notes": null

4
src/amd/compiler/aco_ir.cpp
View file

@ -155,7 +155,9 @@ init_program(Program* program, Stage stage, const struct aco_shader_info* info,
default: break;
}
program->dev.sram_ecc_enabled = program->family == CHIP_MI100;
program->dev.sram_ecc_enabled = program->family == CHIP_VEGA20 ||
program->family == CHIP_MI100 || program->family == CHIP_MI200 ||
program->family == CHIP_GFX940;
/* apparently gfx702 also has fast v_fma_f32 but I can't find a family for that */
program->dev.has_fast_fma32 = program->gfx_level >= GFX9;
if (program->family == CHIP_TAHITI || program->family == CHIP_CARRIZO ||