From 4fa2dbdf553663638d29b87e4db61ee0dbf75d10 Mon Sep 17 00:00:00 2001 From: Georg Lehmann Date: Sun, 18 May 2025 20:36:22 +0200 Subject: [PATCH] aco: assume sram ecc is enabled on Vega20 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There are D16 load issues on Vega20 that are expected if sram ecc is enabled. It's a professional class chip and I found mentions of it supporting ecc, so assume it's enabled. Maybe this could be improved by querying ecc info from the kernel, but I'm not sure which query should be used. Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13189 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12393 Cc: mesa-stable Reviewed-by: Daniel Schürmann Reviewed-by: Rhys Perry Part-of: (cherry picked from commit 025764413001176ccfc4e5cca20c490428d1b36a) --- .pick_status.json | 2 +- src/amd/compiler/aco_ir.cpp | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 7b0641cdd3f..c0c9e33cee2 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -224,7 +224,7 @@ "description": "aco: assume sram ecc is enabled on Vega20", "nominated": true, "nomination_type": 1, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null, "notes": null diff --git a/src/amd/compiler/aco_ir.cpp b/src/amd/compiler/aco_ir.cpp index 937f8e14ef8..b7bd31cb5b0 100644 --- a/src/amd/compiler/aco_ir.cpp +++ b/src/amd/compiler/aco_ir.cpp @@ -155,7 +155,9 @@ init_program(Program* program, Stage stage, const struct aco_shader_info* info, default: break; } - program->dev.sram_ecc_enabled = program->family == CHIP_MI100; + program->dev.sram_ecc_enabled = program->family == CHIP_VEGA20 || + program->family == CHIP_MI100 || program->family == CHIP_MI200 || + program->family == CHIP_GFX940; /* apparently gfx702 also has fast v_fma_f32 but I can't find a family for that */ program->dev.has_fast_fma32 = program->gfx_level >= GFX9; if (program->family == CHIP_TAHITI || program->family == CHIP_CARRIZO ||