fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 18:08:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

panfrost: fix debug print of spilled registers

Browse source 
We were testing some conditions in the wrong order, so spilled
registers were being printed as if they were uniforms. This is
incorrect, but only subtly so, and lead to confusion.

Fixes: 6c64ad934f ("panfrost: spill registers in SSA form")
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Reviewed-by: Ashley Smith <ashley.smith@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37092>
(cherry picked from commit e3552c427e)
This commit is contained in:
Eric R. Smith 2025-08-31 09:23:04 -03:00 • committed by Eric Engestrom
parent b6e6285d9f
commit 3e543205e7
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -9894,7 +9894,7 @@
"description": "panfrost: fix debug print of spilled registers",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "6c64ad934f76dc142926c7a1261ac94d80dca0a9",
"notes": null

4
src/panfrost/compiler/bi_printer.c.py
View file

@ -95,10 +95,10 @@ bi_print_index(FILE *fp, bi_index index)
fprintf(fp, "_");
else if (index.type == BI_INDEX_CONSTANT)
fprintf(fp, "#0x%x", index.value);
else if (index.type == BI_INDEX_FAU && index.value >= BIR_FAU_UNIFORM)
fprintf(fp, "u%u", index.value & ~BIR_FAU_UNIFORM);
else if (index.type == BI_INDEX_FAU && index.memory)
fprintf(fp, "m%u", index.value);
else if (index.type == BI_INDEX_FAU && index.value >= BIR_FAU_UNIFORM)
fprintf(fp, "u%u", index.value & ~BIR_FAU_UNIFORM);
else if (index.type == BI_INDEX_FAU)
fprintf(fp, "%s", bir_fau_name(index.value));
else if (index.type == BI_INDEX_PASS)