fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 07:08:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

panfrost: fix typo in register allocation

Browse source 
The intention of the code was to allow PHI values to be propagated
if they were in registers (as opposed to in memory). As written though
values were never propagated. I think this typo was due to some
debug code that wasn't removed properly.

Fixes: 6c64ad934f ("panfrost: spill registers in SSA form")
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Reviewed-by: Ashley Smith <ashley.smith@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37092>
(cherry picked from commit d482b6ca68)
This commit is contained in:
Eric R. Smith 2025-08-29 14:06:11 -03:00 • committed by Eric Engestrom
parent 8f7563444c
commit b6e6285d9f
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -9904,7 +9904,7 @@
"description": "panfrost: fix typo in register allocation",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "6c64ad934f76dc142926c7a1261ac94d80dca0a9",
"notes": null

2
src/panfrost/compiler/bi_ra.c
View file

@ -965,7 +965,7 @@ bi_out_of_ssa(bi_context *ctx)
}
/* Replace the phi with a move */
allow_propagate = false;
allow_propagate = true;
bi_builder b = bi_init_builder(ctx, bi_before_instr(I));
if (I->dest[0].memory) {
/* dest was spilled to memory */