fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 17:48:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

kopper: Do not free the given screen in initScreen implementation

Browse source 
The given screen is already freed by the caller in case a NULL-pointer is
returned by the implementation.

Cc: mesa-stable
Signed-off-by: Corentin Noël <corentin.noel@collabora.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20933>
(cherry picked from commit dd3730f8bd)
This commit is contained in:
Corentin Noël 2023-01-26 13:25:57 +01:00 • committed by Dylan Baker
parent c172f1de89
commit 3962bcfdae
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -49,7 +49,7 @@
"description": "kopper: Do not free the given screen in initScreen implementation", "description": "kopper: Do not free the given screen in initScreen implementation",
"nominated": true, "nominated": true,
"nomination_type": 0, "nomination_type": 0,
"resolution": 0, "resolution": 1,
"main_sha": null, "main_sha": null,
"because_sha": null "because_sha": null
}, },

1
src/gallium/frontends/dri/kopper.c
View file

@ -171,7 +171,6 @@ fail:
dri_destroy_screen_helper(screen); dri_destroy_screen_helper(screen);
if (screen->dev) if (screen->dev)
pipe_loader_release(&screen->dev, 1); pipe_loader_release(&screen->dev, 1);
FREE(screen);
return NULL; return NULL;
} }