fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 04:38:03 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

zink: disable PIPE_SHADER_CAP_FP16_CONST_BUFFERS

Browse source 
this cap is broken

cc: mesa-stable

fixes:
GTF-GL46.gtf21.GL2Tests.glGetUniform.glGetUniform

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14835>
(cherry picked from commit 9a38dab2d1)
This commit is contained in:
Mike Blumenkrantz 2022-02-02 14:53:45 -05:00 • committed by Eric Engestrom
parent b340c47b69
commit 2ef1287ef7
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1759,7 +1759,7 @@
"description": "zink: disable PIPE_SHADER_CAP_FP16_CONST_BUFFERS",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null
},

6
src/gallium/drivers/zink/zink_screen.c
View file

@ -854,8 +854,10 @@ zink_get_shader_param(struct pipe_screen *pscreen,
return 0; /* not implemented */
case PIPE_SHADER_CAP_FP16_CONST_BUFFERS:
return screen->info.feats11.uniformAndStorageBuffer16BitAccess ||
(screen->info.have_KHR_16bit_storage && screen->info.storage_16bit_feats.uniformAndStorageBuffer16BitAccess);
//enabling this breaks GTF-GL46.gtf21.GL2Tests.glGetUniform.glGetUniform
//return screen->info.feats11.uniformAndStorageBuffer16BitAccess ||
//(screen->info.have_KHR_16bit_storage && screen->info.storage_16bit_feats.uniformAndStorageBuffer16BitAccess);
return 0;
case PIPE_SHADER_CAP_FP16_DERIVATIVES:
return 0; //spirv requires 32bit derivative srcs and dests
case PIPE_SHADER_CAP_FP16: