diff --git a/.pick_status.json b/.pick_status.json index d29598943c2..a4ab624ce58 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -1759,7 +1759,7 @@ "description": "zink: disable PIPE_SHADER_CAP_FP16_CONST_BUFFERS", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": null }, diff --git a/src/gallium/drivers/zink/zink_screen.c b/src/gallium/drivers/zink/zink_screen.c index 6f0f75216f2..0c30e5875c9 100644 --- a/src/gallium/drivers/zink/zink_screen.c +++ b/src/gallium/drivers/zink/zink_screen.c @@ -854,8 +854,10 @@ zink_get_shader_param(struct pipe_screen *pscreen, return 0; /* not implemented */ case PIPE_SHADER_CAP_FP16_CONST_BUFFERS: - return screen->info.feats11.uniformAndStorageBuffer16BitAccess || - (screen->info.have_KHR_16bit_storage && screen->info.storage_16bit_feats.uniformAndStorageBuffer16BitAccess); + //enabling this breaks GTF-GL46.gtf21.GL2Tests.glGetUniform.glGetUniform + //return screen->info.feats11.uniformAndStorageBuffer16BitAccess || + //(screen->info.have_KHR_16bit_storage && screen->info.storage_16bit_feats.uniformAndStorageBuffer16BitAccess); + return 0; case PIPE_SHADER_CAP_FP16_DERIVATIVES: return 0; //spirv requires 32bit derivative srcs and dests case PIPE_SHADER_CAP_FP16: