fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 13:48:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

r600/sfn: Use correct setter method.

Browse source 
Fix warning reported by Coverity Scan.

Useless call (USELESS_CALL)
side_effect_free: Calling v->pin_to_channel() is only useful for its
return value, which is ignored.

Fixes: 5d10e3ec60 ("r600/nir: Pin interpolation results to channel")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5197>
(cherry picked from commit 1241f8cb4c)
This commit is contained in:
Vinson Lee 2020-05-24 17:18:04 -07:00 • committed by Eric Engestrom
parent cf7dffbaae
commit 2e817d95e6
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -706,7 +706,7 @@
"description": "r600/sfn: Use correct setter method.",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "5d10e3ec6066239d732d19f69cd95da447e73e32"
},

2
src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp
View file

@ -149,7 +149,7 @@ void GPRVector::set_reg_i(int i, PValue reg)
void GPRVector::pin_to_channel(int i)
{
auto& v = static_cast<GPRValue&>(*m_elms[i]);
v.pin_to_channel();
v.set_pin_to_channel();
}
void GPRVector::do_print(std::ostream& os) const