From 2e817d95e6907cc260e876bf71bbfeefaf7347b8 Mon Sep 17 00:00:00 2001
From: Vinson Lee <vlee@freedesktop.org>
Date: Sun, 24 May 2020 17:18:04 -0700
Subject: [PATCH] r600/sfn: Use correct setter method.

Fix warning reported by Coverity Scan.

Useless call (USELESS_CALL)
side_effect_free: Calling v->pin_to_channel() is only useful for its
return value, which is ignored.

Fixes: 5d10e3ec6066 ("r600/nir: Pin interpolation results to channel")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5197>
(cherry picked from commit 1241f8cb4c9c6cc65106a085be81963f3505a7d5)
---
 .pick_status.json                              | 2 +-
 src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.pick_status.json b/.pick_status.json
index 0bcfcf046ef..03a176ce0a9 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -706,7 +706,7 @@
         "description": "r600/sfn: Use correct setter method.",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "master_sha": null,
         "because_sha": "5d10e3ec6066239d732d19f69cd95da447e73e32"
     },
diff --git a/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp b/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp
index 35d90a87b22..bc4a0a59e65 100644
--- a/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp
+++ b/src/gallium/drivers/r600/sfn/sfn_value_gpr.cpp
@@ -149,7 +149,7 @@ void GPRVector::set_reg_i(int i, PValue reg)
 void GPRVector::pin_to_channel(int i)
 {
    auto& v = static_cast<GPRValue&>(*m_elms[i]);
-   v.pin_to_channel();
+   v.set_pin_to_channel();
 }
 
 void GPRVector::do_print(std::ostream& os) const