pvr: remove some stale FIXMEs/pvr_finishmes

* The pvr_finishme() in pvr_CreateImage() was added before vk_image_create() was
  being used and is no longer relevant.

* There's nothing special we need to do for the graphics pipeline flags and
  we don't currently store anything in the pipeline cache, so there's nothing
  to finish here.

* The firmware interface now uses fixed sized structures, so remove related
  FIXME.

Signed-off-by: Frank Binns <frank.binns@imgtec.com>
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19578>
This commit is contained in:
Frank Binns 2022-10-24 16:37:15 +01:00 committed by Marge Bot
parent 9ebf72f62a
commit 2d967f74d1
3 changed files with 0 additions and 6 deletions

View file

@ -131,8 +131,6 @@ VkResult pvr_CreateImage(VkDevice _device,
PVR_FROM_HANDLE(pvr_device, device, _device);
struct pvr_image *image;
pvr_finishme("Review whether all inputs are handled\n");
image =
vk_image_create(&device->vk, pCreateInfo, pAllocator, sizeof(*image));
if (!image)

View file

@ -1849,9 +1849,6 @@ pvr_graphics_pipeline_init(struct pvr_device *device,
pvr_pipeline_init(device, PVR_PIPELINE_TYPE_GRAPHICS, &gfx_pipeline->base);
pvr_finishme("ignoring pCreateInfo flags.");
pvr_finishme("ignoring pipeline cache.");
gfx_pipeline->raster_state.discard_enable = raster_discard_enabled;
gfx_pipeline->raster_state.cull_mode =
pCreateInfo->pRasterizationState->cullMode;

View file

@ -425,7 +425,6 @@ struct rogue_fwif_2d_regs {
uint64_t deprecated_1;
uint64_t deprecated_2;
uint64_t deprecated_3;
/* FIXME: HIGH: FIX_HW_BRN_57193 changes the structure's layout. */
uint64_t brn57193_tla_cmd_stream;
};