From 2d967f74d14b9a6964fde9c74879d7ab4827ff91 Mon Sep 17 00:00:00 2001 From: Frank Binns Date: Mon, 24 Oct 2022 16:37:15 +0100 Subject: [PATCH] pvr: remove some stale FIXMEs/pvr_finishmes * The pvr_finishme() in pvr_CreateImage() was added before vk_image_create() was being used and is no longer relevant. * There's nothing special we need to do for the graphics pipeline flags and we don't currently store anything in the pipeline cache, so there's nothing to finish here. * The firmware interface now uses fixed sized structures, so remove related FIXME. Signed-off-by: Frank Binns Reviewed-by: Karmjit Mahil Part-of: --- src/imagination/vulkan/pvr_image.c | 2 -- src/imagination/vulkan/pvr_pipeline.c | 3 --- src/imagination/vulkan/winsys/pvrsrvkm/fw-api/pvr_rogue_fwif.h | 1 - 3 files changed, 6 deletions(-) diff --git a/src/imagination/vulkan/pvr_image.c b/src/imagination/vulkan/pvr_image.c index 673df51c12f..8f43682d0f0 100644 --- a/src/imagination/vulkan/pvr_image.c +++ b/src/imagination/vulkan/pvr_image.c @@ -131,8 +131,6 @@ VkResult pvr_CreateImage(VkDevice _device, PVR_FROM_HANDLE(pvr_device, device, _device); struct pvr_image *image; - pvr_finishme("Review whether all inputs are handled\n"); - image = vk_image_create(&device->vk, pCreateInfo, pAllocator, sizeof(*image)); if (!image) diff --git a/src/imagination/vulkan/pvr_pipeline.c b/src/imagination/vulkan/pvr_pipeline.c index 55abe4590e4..778e30b9faf 100644 --- a/src/imagination/vulkan/pvr_pipeline.c +++ b/src/imagination/vulkan/pvr_pipeline.c @@ -1849,9 +1849,6 @@ pvr_graphics_pipeline_init(struct pvr_device *device, pvr_pipeline_init(device, PVR_PIPELINE_TYPE_GRAPHICS, &gfx_pipeline->base); - pvr_finishme("ignoring pCreateInfo flags."); - pvr_finishme("ignoring pipeline cache."); - gfx_pipeline->raster_state.discard_enable = raster_discard_enabled; gfx_pipeline->raster_state.cull_mode = pCreateInfo->pRasterizationState->cullMode; diff --git a/src/imagination/vulkan/winsys/pvrsrvkm/fw-api/pvr_rogue_fwif.h b/src/imagination/vulkan/winsys/pvrsrvkm/fw-api/pvr_rogue_fwif.h index abb251d39f8..983a33f5ce2 100644 --- a/src/imagination/vulkan/winsys/pvrsrvkm/fw-api/pvr_rogue_fwif.h +++ b/src/imagination/vulkan/winsys/pvrsrvkm/fw-api/pvr_rogue_fwif.h @@ -425,7 +425,6 @@ struct rogue_fwif_2d_regs { uint64_t deprecated_1; uint64_t deprecated_2; uint64_t deprecated_3; - /* FIXME: HIGH: FIX_HW_BRN_57193 changes the structure's layout. */ uint64_t brn57193_tla_cmd_stream; };