fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-06 15:20:17 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Add zsa->zs_always_passes flag

Browse source 
If we know ahead-of-time that depth/stencil testing will always pass, it's
better to use weak_early than force_early. However, if depth/stencil testing
could fail (discarding pixels), we'd rather use force_early. Determine which
case we're in at CSO create time.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17428>
This commit is contained in:
Alyssa Rosenzweig 2022-07-12 17:14:31 -04:00 • committed by Marge Bot
parent fe875c0144
commit 2454531de4
1 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/gallium/drivers/panfrost/pan_cmdstream.c
View file

@ -65,6 +65,11 @@ struct panfrost_zsa_state {
/* Is any depth, stencil, or alpha testing enabled? */
bool enabled;
/* Does the depth and stencil tests always pass? This ignores write
* masks, we are only interested in whether pixels may be killed.
*/
bool zs_always_passes;
#if PAN_ARCH <= 7
/* Prepacked words from the RSD */
struct mali_multisample_misc_packed rsd_depth;
@ -4362,6 +4367,21 @@ pan_pipe_to_stencil(const struct pipe_stencil_state *in,
}
#endif
static bool
pipe_zs_always_passes(const struct pipe_depth_stencil_alpha_state *zsa)
{
if (zsa->depth_enabled && zsa->depth_func != PIPE_FUNC_ALWAYS)
return false;
if (zsa->stencil[0].enabled && zsa->stencil[0].func != PIPE_FUNC_ALWAYS)
return false;
if (zsa->stencil[1].enabled && zsa->stencil[1].func != PIPE_FUNC_ALWAYS)
return false;
return true;
}
static void *
panfrost_create_depth_stencil_state(struct pipe_context *pipe,
const struct pipe_depth_stencil_alpha_state *zsa)
@ -4428,6 +4448,8 @@ panfrost_create_depth_stencil_state(struct pipe_context *pipe,
so->enabled = zsa->stencil[0].enabled ||
(zsa->depth_enabled && zsa->depth_func != PIPE_FUNC_ALWAYS);
so->zs_always_passes = pipe_zs_always_passes(zsa);
/* TODO: Bounds test should be easy */
assert(!zsa->depth_bounds_test);